Re: [PATCH] ASoC: rcar: adg: correct TIMSEL setting for SSI9

[Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>]

Hello Morimoto-san,

On Tue, Feb 27, 2024 at 11:22:53PM +0000, Kuninori Morimoto wrote:
> 
> > > +	/*
> > > +	 * SSI8 is not connected to ADG.
> > > +	 * Thus SSI9 is using 8
> > > +	 */
> > > +	if (id == 9)
> > > +		ws = 8;
> (snip)
> > Quick/preliminary verification attempts showed that it might not be
> > fully equivalent to the original patch
> 
> If it is indicating that above simple code doesn't care about
> SSI8 error case, I don't think it needs to care about it.

A number of concerns have been raised internally, related to the fact
that the "optimized/simplified" counter-proposal behaves differently
depending on the value returned by rsnd_ssi_is_pin_sharing().

> Because SSI8 with shared pin setting is *mandatory*.

While it may be clear for you that pin sharing is mandatory, it is not
immediately obvious to the casual reader/contributor purely based on
code review. From this particular viewpoint, I would rather vote in
favor of the original patch authored by Andreas (Cc), since it makes
things very clear and does not hide any dependencies/assumptions.

Please, kindly provide your verdict, so that we can proceed with the
right solution, due to the issue being time critical for us.

BR, Eugeniu