Udo Richter wrote: > Helmut Auer wrote: >>> Since you query cPluginManager::Active() twice (no comment on style...) >> If you don't want to comment then be quiet - what you've written is a >> comment ! > > Yeah, sorry for for doing a NULL comment. ;) > >> But to call it twice is the only way to differentiate between no >> active plugin active and a user interaction. > > Calling it twice is creative, but not very elegant. Active() could be > modified, but I didn't want to go that far. In the end, I liked the idea > being asked separately for each reason not to shut down, so there's no > need to know how forced the shutdown was. > >> Anyway, if you talk about style you should recode the whole shutdown >> part, because it wouldn't pass any code review ;) > > The shutdown part, and lots of things in the main loop, but > unfortunately 1.4.0 is supposed to be a stable version. ;) Please let's focus on the actual problem ;-) Klau
