On Mon, Aug 24, 2009 at 07:54:20PM +0200, Alessandro Zummo wrote:
> On Mon, 24 Aug 2009 10:30:38 -0400
> Paul Fox <pgf@xxxxxxxxxx> wrote:
>
> > > or rtc_read_alarm_internal could be patched
> > > to initialize that field to -1 prior to the call to ops->read_alarm
> >
> > i don't think that's sufficient (or even, perhaps, necessary) -- is
> > it? it's not reading the alarm time where the problem lies.
> >
> > as james cameron pointed out, the issue is that ioctl(fd,
> > RTC_RD_TIME, &rtc) returns a bogus '0' value in the tm_isdst
> > field. the kernel and RTC drivers should be fixed to contrive
> > that this field is reported reliably as "don't know", i.e. -1.
>
> right, then we can patch rtc_read_time
Just for the record, hwclock(8) also doesn't use tm_isdst from
RTC_RD_TIME ioctl.
I'm going to commit the original Paul's rtcwake patch. That's
probably safer to follow mktime(3) than assume correct tm_isdst value
from kernel :-)
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
