On Fri, Aug 14, 2009 at 10:51:35AM +1000, James Cameron wrote: > drivers/chat/rtc.c forces tm_isdst zero, due to a call to memset and > then not changing it in rtc-cmos.c ... and so per mktime(3) this implies > that "daylight saving time" is not in effect. > > It would be more correct for the kernel to return -1 in this field as a > result of the RTC_RD_TIME ioctl. But it doesn't. So we're compensating > for this in rtcwake by ignoring the value. > > Looking at the other rtc drivers, some of them *do* set tm_isdst to -1, > some of them (especially rtc-efi) set tm_isdst to real data ... so I'm > not sure this patch to rtcwake will work right on EFI based systems. > > Would it be better to say this is a kernel RTC driver problem, in that > it is returning 0 instead of -1 in tm_isdst? Redirecting to RTC guys, see http://thread.gmane.org/gmane.linux.utilities.util-linux-ng/2516 Thanks for investigation. Karel -- Karel Zak <kzak@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
