Re: [PATCH] ignore RTC's notion of DST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



drivers/chat/rtc.c forces tm_isdst zero, due to a call to memset and
then not changing it in rtc-cmos.c ... and so per mktime(3) this implies
that "daylight saving time" is not in effect.

It would be more correct for the kernel to return -1 in this field as a
result of the RTC_RD_TIME ioctl.  But it doesn't.  So we're compensating
for this in rtcwake by ignoring the value.

Looking at the other rtc drivers, some of them *do* set tm_isdst to -1,
some of them (especially rtc-efi) set tm_isdst to real data ... so I'm
not sure this patch to rtcwake will work right on EFI based systems.

Would it be better to say this is a kernel RTC driver problem, in that
it is returning 0 instead of -1 in tm_isdst?

-- 
James Cameron
http://quozl.linux.org.au/
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux