Re: [PATCH] ignore RTC's notion of DST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 13, 2009 at 11:35:53AM -0400, Paul Fox wrote:
> several people have noticed a problem with rtcwake on recent
> releases built for the XO laptop.  as it happens, the symptoms
> exactly match this recently-reported debian bug:
>     http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=539347
> 
> i believe the issue is that rtcwake honors tm_isdst as returned
> from the RTC (whose value on the XO is 0), and this incorrectly
> influences the result of mktime.  i suspect that the system's
> knowledge of DST will usually be more correct than that of the
> RTC, and so the RTC's notion should be ignored.
> 
> i've tested this with both -s and -t alarm setting options, and it
> seems to do the right thing.
> 
> (a workaround, at least for the -s "relative time" case, is
> simply to pass "--utc" on the rtcwake commandline.  it's arguable
> that rtcwake should ignore timezones when -s is used in any
> case.)
> 
> paul
> 
> 
> commit c0541b637ac9717cb931cb7ea0847756b618932c
> Author: Paul Fox <pgf@xxxxxxxxxx>
> Date:   Thu Aug 13 10:50:50 2009 -0400
> 
>     ignore the tm_isdst field returned from the RTC, since we don't use
>     it when setting the alarm time.
>     
>     Signed-off-by: Paul Fox <pgf@xxxxxxxxxx>

 Applied, thanks.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux