Re: review request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 03, 2007 at 09:20:04PM +0200, Karel Zak wrote:
> On Tue, Apr 03, 2007 at 04:20:54PM +0200, Matthias Koenig wrote:
> > I am having some problems with the build of the current devel branch
> > related to the wchar.h header. It seems that wcwidth and wcswidth
> > are only declared if _GNU_SOURCE is defined. I am still not sure what
> 
> > the correct behaviour should be, i.e. if this should fixed in the
> > widechar.h header.
> 
>  I think the best solution is add AC_GNU_SOURCE to configure.ac

On Fri, Apr 13, 2007 at 08:08:55AM -0400, Mike Frysinger wrote:
> A few .c files define _GNU_SOURCE but not enough ... a bunch of
> files miss wcwidth prototype because this is only included when
> _GNU_SOURCE is in effect.  Move _GNU_SOURCE to configure.ac and
> everything is peachy.

 Well, I've added the AC_GNU_SOURCE to configure.ac (although I don't
 see the problem with _GNU_SOURCE on Fedora).

> Also, -fsigned-char is a CFLAG, not a CPPFLAG.  Aaaalso, drop
> -fomit-frame-pointer as that sort of build option should be left up
> to the person building util-linux (and can be annoying when trying
> to build up an actual debug version).

 The -fomit-frame-pointer has been removed.

 The other new feature is SUID_{CFLAGS,LDFLAGS} ...  if you want to
 define special compiler options for typical suid programs (mount,
 umount, ...), for example:

    ./configure SUID_CFLAGS="-fpie" SUID_LDFLAGS="-pie"


 All these changes will be committed today together with 36 (!)
 patches to the util-linux-ng build system from Stepan Kasal.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux