review request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 Hi folks,

 I'd like to inform you about actual project state.

 I've applied and fix almost all minor and less critical things. There
 was also many problems with package build system (autotools).

 Now in my patches queue are changes to login-utils, mount and
 partitioning tools.

 I'd like to release a snapshot from the devel branch -- my
 approximation is someday around 25-Feb-2007.

 If there is someone who wants to test and review these changes:

$ git clone git://git.kernel.org/pub/scm/utils/util-linux-ng/util-linux-ng.git util-linux-ng
$ git checkout -f devel


 Please, don't use gitweb at kernel.org it still seems broken :-(

    Karel


Change log:

commit 1c51a3683a1e1ae589e1ec294f1153f4f567f899
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Mar 7 01:03:28 2007 +0100

    todo: add item about ipcs

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit f2c7ae1ddd5973c578d73ec929f29205e84aa47a
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Mar 6 15:08:58 2007 +0100

    login: close PAM session after failed pam_setcred

    If for some reason the pam set credential call fails, it does not close the pam
    session. pam open can mount drives, so calling pam close is important.

    From: Steve Grubb <sgrubb@xxxxxxxxxx>
    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 7ab59baf58c317662afaa3ae83537ccd4c4aea65
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Mar 6 13:45:59 2007 +0100

    chsh: remove tailing wihit-spaces and use PATH_BSHELL

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 429ee99745c92cc283472db5efa1c7162f43c2cc
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Mar 7 09:53:56 2007 +0100

    look: remove tailing white-spaces

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit dab737cc42a844e439b58562804f4ce60689c792
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Mar 6 13:14:52 2007 +0100

    look: fix problem with !isalnum() words

    for example "$ look apple-pie"

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit a17bead499741b5a3844f0d7a9bc82ad1788ba99
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Mar 6 13:04:25 2007 +0100

    tests: add look test for words with separator

    	$ look apple-pie

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 8b0f4ae981950c641f5ff23bcf2a4ed47e8c1f5f
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Mar 6 12:03:19 2007 +0100

    po: vipw doesn't use rpmatch, all translations have to use y/n

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 1bf100f33b39f7de0ccb0e26270e985a6a9f8f27
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Mar 6 11:54:39 2007 +0100

    cfdisk: build-sys defines HAVE_RPMATCH, not HAVE_rpmatch

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 2bfcd20b8d78ee9191cbfc4ea420f44ecdfb25cd
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Feb 27 16:49:25 2007 +0100

    mkfs.cramfs: fix a way how mkfs works with empty files

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 40b115acc5f5bacd59436ebd9ea4ab8b785e9700
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Feb 27 16:38:27 2007 +0100

    tests: add expected outputs for cramfs

    The patch aslo reduce number of files and dirs in mkfs.cramfs tests.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 3e52b13e91a8d4935af17974a59843bb7ea854b9
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Feb 27 16:31:21 2007 +0100

    mkfs.cramfs: remove hardcoded limit for directories

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 86ec1b63f90bcf534292f3ddd9da9749c00d84ba
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Feb 27 15:59:04 2007 +0100

    tests: add mkfs.cramfs tests

    This test shows that actual mkfs.cramfs is ugly due MAXENTRIES (100) limit.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 31ffd207d207818e3e7e7060fdd51971752a3007
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Feb 15 11:46:23 2007 +0100

    vipw: fix permissions (600->400) for edited /etc/[g]shodow files

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 2f2d6528e3af6d9722e44727064a7a86b42b9168
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Fri Feb 9 19:15:23 2007 +0100

    partx: add man pages for addpart, delpart and partx

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 4717ea4a97af59fca6a88a84e10add5d9539a473
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Fri Feb 9 17:35:15 2007 +0100

    clean up realpath.[ch] includes and macros

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 167eaed7836b456b7bedf38be4124a8fa27ccb69
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Fri Feb 9 17:15:39 2007 +0100

    swapon: does not correctly deal with symlinks

    From: Marco d'Itri <md@xxxxxxxx>
    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 3e18b040af55bd6fcd06dc0008f7a4e00f6fc123
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Feb 8 15:22:37 2007 +0100

    mkswap: automatically add selinux label to swapfile

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit deef0ba55e45e275e4f23bdf93fcd24c0750d8ae
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Feb 8 15:19:36 2007 +0100

    build-sys: configure.am selinux support cleanup

    Changes:
     - don't include SELinux as default (--with-selinux is required)
     - the SELinux is not useful for login-utils only
     - clean up PAM and login-utils tests in the configure.am

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit b8d1314dc6ceeb998632102d5f93cda5e2548f8d
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Feb 8 12:38:25 2007 +0100

    build-sys: fix README filenames and add missing files to EXTRA_DISTs

    Also, the patch makes "make mrproper" more robust.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 061999ee0d9bde9e79f4735283dfd1382313bccf
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Feb 7 13:26:11 2007 +0100

    mkswap: add regression test

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 85ffb958a9c609b4c54e558320d39a2a4499a9e1
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Feb 7 10:32:34 2007 +0100

    todo: add item about exit() codes

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 8abb4c2e002c0dba05a011a0c17b5582a54d3a71
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Feb 7 10:32:02 2007 +0100

    mkswap: avoid mkswap usage on already mounted device

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit f93a4afd47d331e63da9582aad83ffc3db15fa70
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Feb 7 10:11:07 2007 +0100

    todo: add this file

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 6b9a290adf1680ff7a4a74bc78fe6ac9931667cc
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Feb 7 10:10:22 2007 +0100

    mkswap: gcc happy: unsigned long usage

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 7ac3b5b8e3ec944e7cd3bcc6d992882c4d443414
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Feb 6 11:35:15 2007 +0100

    Clean up pagesize/PAGE_SIZE usage.

    Now all code in util-linux uses sysconf(_SC_PAGESIZE) that is standardized and
    preferred way of querying page size. The asm/page.h file is not included to the
    code anymore. (This patch doesn't change mount's FS detection code which will
    be removed later).

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit ca04734de12f317e4fa47da0ad6e7e3b45e8b3a8
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Feb 6 11:33:35 2007 +0100

    tests: fix argv[] usage in mnt_test_sysinfo.c

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 5db4f8e3b381accb46f31dec5767241782953fa2
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Jan 31 16:45:01 2007 +0100

    namei: new regression test

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit d8ef4c19ab6ebe29b1deb5d5445cba6d76192a4f
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Jan 31 16:43:18 2007 +0100

    namei: fix logic and infinite loop of symlinks

    Don't follow the path if a component is not directory.  It doesn't make sense
    to support something like:

    	$ touch a b
    	$ namei a/b  <-- where "a" is not directory

    The support for infinite loop of symbolic links is a strange wish only. The
    stack size is very limited. Try:

    	$ ln -s x
    	$ namei x/x

    [Migration note: severity="low"]

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit e9ce5ccc90c63cb1c499ad01800e638ece23f8b0
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Jan 30 13:18:51 2007 +0100

    col: getwchar() errors shouldn't be hidden

    The col truncates output when multibyte errors is detected, but the problem is
    not reported to stderr and return code is still same like for successful exit.
    This stupid behaviour is fixed by this patch.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 06b04b23cdff2f038e4f341a1247c51b5261f332
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Jan 30 13:49:50 2007 +0100

    build-sys: fix ifdef ENABLE_WIDECHAR usage

    There has been unexpected mix of HAVE_WIDECHAR and ENABLE_WIDECHAR macros. The
    ENABLE_WIDECHAR is old version and has to be replaced everywhere otherwise we
    will see bugs with multibyte stuff.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 5b0d01d619beafb50dfb6b62bdff2dfd364fab8c
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Sun Jan 28 01:24:15 2007 +0100

    tests: add return code

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit b6b6c3e3ebcf84ba71f91a84a43eacb8c67e115e
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Fri Jan 26 20:06:38 2007 +0100

    raw: add file with udev rule example

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 3f88ee97319e2662c7a6369f5f3565c9b03ac065
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Fri Jan 26 20:01:39 2007 +0100

    raw: move the raw command to /sbin

    The raw command could be used from udev scripts.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 34ab1590bd5001801e3417456161bd77265425f7
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Fri Jan 26 19:55:41 2007 +0100

    raw: don't accept raw0 as a target name

    The raw0 is rawctl and cannot be used as a normal raw device. The patch
    also enlarge range of <N> for raw<N> and improve the query mode.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 69616d88d47f51147480a64962f1fed91f9b8732
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Jan 25 11:22:42 2007 +0100

    raw: update man page (about dd and O_DIRECT)

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 42c9ce52aaf4d5a060ac435a9a988005a8e0807a
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Jan 17 14:27:15 2007 +0100

    hexdump: don't use memset with zero lenght

    gcc 4.1.0: "warning: memset used with constant zero length parameter...."

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit df3773fba068c88ec4ce2d3b65dec57146d2b730
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Jan 16 15:24:13 2007 +0100

    schedutils: add support for SCHED_BATCH

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 5ee003094ef4c4410f17c171140c29368804dc29
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Tue Jan 16 14:30:24 2007 +0100

    schedutils: remove extra hyptens from man pages

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit b268a0714a5d75bc17b94932c8f7eb23103a00ac
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Jan 4 15:02:25 2007 +0100

    po: rename mount/mntent.c to mount/mount_mntent.c

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit b30cd7eed5b70c5eaf08f8681eb3f717c4d11329
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Jan 3 01:07:55 2007 +0100

    ipcs: add new tests for ipcs limits

    The tests check if data from kernel and from the ipcs command are same.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 0f0584addc6c6301836455724d32a98b02cae159
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Jan 4 14:53:19 2007 +0100

    tests: add simple helper that returns info about system

    usage: tests/helpers/mnt_test_sysinfo <infoname>

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit cdd540c19f6c6360809b320a64f00a938dea4744
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Fri Dec 29 01:13:58 2006 +0100

    ipcs: max total shared memory in kbytes instead pages

    The ipcs command has reported "max total shared memory" as a number of pages.
    The others IPC limits are reported in (k)bytes, so it doesn't make sense mix
    pages and bytes in the same output. Now "max total shared memory" is reported in
    kbytes.

    [Migration note: type="API change", severity="low"]

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 4ac0f9d0c292c7d851e5931efc48819f6276d441
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Dec 28 23:09:29 2006 +0100

    ipcs: fix typo in Semaphore headers

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 97cdb3cb5c7c20da3bc28962001b33c4ea083d69
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Jan 3 00:42:23 2007 +0100

    ipcs: add regression test for output headers

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 8271f58d5122e2c8a9a68653767d6ca50692040c
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Jan 3 00:28:02 2007 +0100

    more: fix file descriptor leak

    When you view a file with the more command and run a shell, the file descriptor
    for reading the file is leaked to that process.

    To test, more any file. Then do !/bin/sh. At the prompt do "ls -l /proc/$$/fd"
    and you'll see the leaked fd.

    From: Steve Grubb <sgrubb@xxxxxxxxxx>
    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit d057115966720db64c3fbf7b2f3821709fe0a08c
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Dec 28 22:26:02 2006 +0100

    execl() should be use NULL not 0

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 8174c9ca720fdcb98f0da09de792ecea9d340691
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Jan 4 14:39:17 2007 +0100

    build-sys: remove DEFAULT_INCLUDES workaround

    The automake stuff uses "-I.". as a default gcc option for includes. This is a
    problem for source code where is local includes with a same name like system
    includes (e.g.  mntent.h, paths.h). Possible workaround is overwrite the
    automake DEFAULT_INCLUDES variable. But this solution produces warnings. The
    best way (this patch) is probably rename the files and remove DEFAULT_INCLUDES.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit e83446da1a3f626920d5e65d4f78651581765b61
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Jan 4 14:23:48 2007 +0100

    tests: add basic infrastructure for regression tests

    The patch adds tests/ directory with simple regression tests infrastructure.

    Also, it adds the "ts-mount-paths" test that testing if all defined paths
    (fstab, mtab, locks) are still same.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 61d9d2ff1cb0e28e2b88099bbc5b919fa5004fce
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Dec 27 23:35:56 2006 +0100

    mount: add simple (printf-like) debug routine and --debug option

    The --debug=<level> command line option enables debug outputs. It's
    undocumented option, because it's really for debug/tests purpose only.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 5bbc26de59732f9a24d98a769c2d7a827e550625
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Jan 4 13:44:06 2007 +0100

    build-sys: rename to -ng, change maintainer name

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 562218e6ea1926723045713e52449c24c6ccff1f
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Thu Jan 4 11:57:07 2007 +0100

    build-sys: add missing files

    This patch add all missing headers, man pages and README files to automake
    stuff and "make dist-gzip" produces useful tarball now.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

commit 8eeb575c0d4a0a7af62615829ae99fed4ee3c08c
Author: Karel Zak <kzak@xxxxxxxxxx>
Date:   Wed Jan 3 22:20:44 2007 +0100

    build-sys: remove generated autotools stuff from git

    The generated autotools stuff shouldn't be maintained by SCM. After check out
    from git use ./autogen.sh. For more details see README.devel.

    Signed-off-by: Karel Zak <kzak@xxxxxxxxxx>

--
 Karel Zak  <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux