[PATCH] Cleanup CFLAG/CPPFLAG handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A few .c files define _GNU_SOURCE but not enough ... a bunch of files miss wcwidth prototype because this is only included when _GNU_SOURCE is in effect.  Move _GNU_SOURCE to configure.ac and everything is peachy.

Also, -fsigned-char is a CFLAG, not a CPPFLAG.  Aaaalso, drop -fomit-frame-pointer as that sort of build option should be left up to the person building util-linux (and can be annoying when trying to build up an actual debug version).
---
 configure.ac             |    3 ++-
 disk-utils/fsck.cramfs.c |    1 -
 schedutils/chrt.c        |    2 --
 schedutils/taskset.c     |    2 --
 4 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/configure.ac b/configure.ac
index 66e88df..2de896c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -398,7 +398,8 @@ if test x$enable_use_tty_group = xyes; then
   AC_DEFINE(USE_TTY_GROUP, 1, [Should wall and write be installed setgid tty?])
 fi
 
-CPPFLAGS="-fsigned-char -fomit-frame-pointer $CPPFLAGS"
+CFLAGS="-fsigned-char $CFLAGS"
+CPPFLAGS="-D_GNU_SOURCE $CPPFLAGS"
 
 LIBS=""
 
diff --git a/disk-utils/fsck.cramfs.c b/disk-utils/fsck.cramfs.c
index 68bbf51..117ee6e 100644
--- a/disk-utils/fsck.cramfs.c
+++ b/disk-utils/fsck.cramfs.c
@@ -36,7 +36,6 @@
 /* compile-time options */
 //#define INCLUDE_FS_TESTS	/* include cramfs checking and extraction */
 
-#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdarg.h>
 #include <unistd.h>
diff --git a/schedutils/chrt.c b/schedutils/chrt.c
index 4c190a8..1b52b09 100644
--- a/schedutils/chrt.c
+++ b/schedutils/chrt.c
@@ -21,8 +21,6 @@
  * Copyright (C) 2004 Robert Love
  */
 
-#define _GNU_SOURCE
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <sched.h>
diff --git a/schedutils/taskset.c b/schedutils/taskset.c
index 2590d99..573c891 100644
--- a/schedutils/taskset.c
+++ b/schedutils/taskset.c
@@ -26,8 +26,6 @@
  * Copyright (C) 2004 Robert Love
  */
 
-#define _GNU_SOURCE
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
-- 
1.5.1

-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux