On Mon, Feb 19, 2018 at 12:08:34PM +0100, list@xxxxxxxxxxxxxxxxxx wrote: > On 2018-02-19 07:54, Sascha Hauer wrote: > > On Sat, Feb 17, 2018 at 10:18:16AM +0100, Andreas Schmidt wrote: > [...] > > > On 16.02.2018 08:39, Sascha Hauer wrote: > > > > No need to call mdiobus_scan() manually. it is called from > > > > phy_device_connect() already in cpsw_open() which does all > > > > the magic to connect a network device with its phy. > > > You added call of mdiobus_scan to check if the slave has valid phy, > > > I guess. > > > Or I misunderstood your commit: > > > b2568de82d62c18fd5dc8affb0e4dc050403c498 > > > net: cpsw: ignore error on slave setup ? > > > > > > I guess it should work in follow: > > > If slave has a valid phy (determined by mdiobus_scan), slave will be > > > continue to register (call eth_register), > > > if not, cpsw_clave_setup function will exit with an error and next > > > slave > > > will be try to register. > > > > You're right. I have overlooked the case that we do not want to register > > ethernet devices for slaves which do not have a valid phy. > > > > In this case, how about the following variant? > Yes, it's better. I tested it with fixed-link and with real phy and it > works. > Except a little bug, see comments below. Ok, applied with your fixup added. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
