Re: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/10/2015 at 23:48:01 +0200, Alessandro Rubini wrote :
> From: Edoardo Scaglia <scaglia@xxxxxxxxxxxx>
> 
> The ROM base address in the 9x5 processors lives at 1M, not 4M,
> where SMD is, as defined later in the same file.
> 
> The ROM includes some tables that are used to build error-correction data
> for NAND memory.  By using the wrong address, we get wrong data and
> the result is undetected bit flips (data at 0x408000 is all zeroes).
> 
> Thus, even though our kernel was fixing bit errors in NAND, barebox
> was not fixing them. With UBI (our situation) we got I/O errors because
> the checksum verification for data nodes failed.
> 
> Using the proper address corrects the problem: barebox reports a
> "bitflip" message, consistent with the kernel message for the same
> file, and the files are properly loaded and booted.
> 
> Note: the kernel has the same wrong define, but then the magic number
> 0x00108000 as spelled in arch/arm/boot/dts/at91sam9x5.dtsi is used
> instead of the symbolic name.
> 
> Signed-off-by: Edoardo Scaglia <scaglia@xxxxxxxxxxxx>
> Signed-off-by: Federico Braghiroli <braghiroli@xxxxxxxxxxxx>
> Signed-off-by: Alessndro Rubini <rubini@xxxxxxxxx>
                     ^
Typo in your name here


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux