Re: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Subject: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)

Argh! After a lot of editing, the subject line is wrong.

   fix ROM base address (bugfix for nand ECC)

Anyways, let me add this detail.  The current code considers the
case where dev_request_mem_region() fails.

        host->pmecc_rom_base = dev_request_mem_region(dev, 3);
        if (!host->pmecc_rom_base) {
                   [...]

What it does in "[...]" is creating the tables with proper math..  I
tried to skip the request_mem_region() above and ECC works perfectly,
with the software-generated table.

So I wonder whether it makes sense to just remove the declaration of
the ROM are memory-region-3 for NAND, and just use the software-built
tables.

This wouldn't void the previous patch: the ROM address is wrong
as defined, for all CPU types that fall under "at91sam9x5" (I checked
the 5 data sheets: G15, G35, X25, G25, X35).

thanks
/alessandro

_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox



[Index of Archives]     [Linux Embedded]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux