Hello Jürgen, when going to bed yesterday^Wearlier today I remembered that I wantet do Cc: you for this series. Great you noticed it anyhow :-) On Fri, Oct 24, 2014 at 09:50:21AM +0200, Juergen Borleis wrote: > Hi Uwe, > > On Friday 24 October 2014 00:46:00 Uwe Kleine-König wrote: > > [...] > > #if defined CONFIG_ARCH_IMX23 > > +/* > > + * The pin definition of i.MX23 are strange. Bank 0's pins 0 .. 15 are defined > > + * using PORTF(0, 0) .. PORTF(0, 15). Its pins 16 .. 31 however use PORTF(1, 0) > > + * .. PORTF(1, 15). So the PORTF macro is more ugly than necessary. > > + */ > > +# define PORTF(bank,bit) (BANK((bank) / 2) | BANKPIN((((bank) & 1) << 4) | (bit)) | ERROR((bit) & ~15) | ERROR((bank) & ~7) > > +# define VE_2_5V VOLTAGE(1) > > # include <mach/iomux-imx23.h> > > #endif > > + > > Looks more like a strange implementation by myself. Did not remember why I have > done it in this way... When Sascha is happy with the changes in this series we can clean that up. You didn't test that on an i.MX23 machine, do you? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
