Hello, this series helped me to find pinmuxing problems on an i.MX28 machine. The pins either have a pull up, a bit keeper or neither. For example the pin ENET0_RXD2 has a bit keeper, and so doing imx_gpio_mode(ENET0_RXD2 | VE_3_3V | STRENGTH(S8MA) | PULLUP(1)) obviously couldn't enable the pull up as requested. Instead it enabled the bit keeper. With this series the above call results in a message that the mode is invalid and the pullup and bitkeeper register settings are not touched. Note that I didn't test on i.MX23 even though this SoC is affected, too. I currently don't have an i.MX23 handy, so I couldn't test this part. Uwe Kleine-König (3): mxs: iomux-imx28: Fix keeper/pullup/drive strength/voltage flags mxs: iomux-imx23/imx28: unify mode definition mxs: iomux-imx23/imx28: add additional checks on mode arch/arm/mach-mxs/include/mach/iomux-imx23.h | 61 --------------- arch/arm/mach-mxs/include/mach/iomux-imx28.h | 112 +++++++-------------------- arch/arm/mach-mxs/include/mach/iomux.h | 82 ++++++++++++++++++++ arch/arm/mach-mxs/iomux-imx.c | 23 +++++- 4 files changed, 127 insertions(+), 151 deletions(-) -- 2.1.1 _______________________________________________ barebox mailing list barebox@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/barebox
