On Fri, Dec 09, 2011 at 03:56:01PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:28 Fri 09 Dec , Michael Grzeschik wrote:
> > Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> > ---
> > arch/arm/mach-at91/at91sam9260_devices.c | 9 +++++++--
> please update all soc
> > 1 files changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c
> > index 177f770..be1fdd9 100644
> > --- a/arch/arm/mach-at91/at91sam9260_devices.c
> > +++ b/arch/arm/mach-at91/at91sam9260_devices.c
> > @@ -63,8 +63,13 @@ void at91_add_device_eth(struct at91_ether_platform_data *data)
> > at91_set_B_periph(AT91_PIN_PA25, 0); /* ERX2 */
> > at91_set_B_periph(AT91_PIN_PA26, 0); /* ERX3 */
> > at91_set_B_periph(AT91_PIN_PA27, 0); /* ERXCK */
> > - at91_set_B_periph(AT91_PIN_PA23, 0); /* ETX2 */
> > - at91_set_B_periph(AT91_PIN_PA24, 0); /* ETX3 */
> > + if (data->flags & AT91SAM_ETX2_ETX3_ALTERNATIVE) {
> I really don't like the idea to propagate pin configuration to the drivers
> this show stay at board or soc config level
The same is already done with RMII:
if (!(data->flags & AT91SAM_ETHER_RMII)) {
at91_set_B_periph(AT91_PIN_PA28, 0); /* ECRS */
at91_set_B_periph(AT91_PIN_PA29, 0); /* ECOL */
at91_set_B_periph(AT91_PIN_PA25, 0); /* ERX2 */
...
>
> I prefer to add a new parameter than use a flag use by the driver
-ENOPARSE
A new parameter to what? at91_add_device_eth?
The driver itself does not use this flag.
> please make this more generic alt_config1 as this will what is going to be use
> by the pinctrl on at91
Sorry, don't know what you mean.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
