On 12:28 Fri 09 Dec , Michael Grzeschik wrote:
> Signed-off-by: Michael Grzeschik <m.grzeschik@xxxxxxxxxxxxxx>
> ---
> arch/arm/mach-at91/at91sam9260_devices.c | 9 +++++++--
please update all soc
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c
> index 177f770..be1fdd9 100644
> --- a/arch/arm/mach-at91/at91sam9260_devices.c
> +++ b/arch/arm/mach-at91/at91sam9260_devices.c
> @@ -63,8 +63,13 @@ void at91_add_device_eth(struct at91_ether_platform_data *data)
> at91_set_B_periph(AT91_PIN_PA25, 0); /* ERX2 */
> at91_set_B_periph(AT91_PIN_PA26, 0); /* ERX3 */
> at91_set_B_periph(AT91_PIN_PA27, 0); /* ERXCK */
> - at91_set_B_periph(AT91_PIN_PA23, 0); /* ETX2 */
> - at91_set_B_periph(AT91_PIN_PA24, 0); /* ETX3 */
> + if (data->flags & AT91SAM_ETX2_ETX3_ALTERNATIVE) {
I really don't like the idea to propagate pin configuration to the drivers
this show stay at board or soc config level
I prefer to add a new parameter than use a flag use by the driver
please make this more generic alt_config1 as this will what is going to be use
by the pinctrl on at91
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/barebox
