On Wed, Apr 08, 2020 at 05:53:52AM +0000, Y.b. Lu wrote: > Hi Daniel, > > > -----Original Message----- > > From: Daniel Walker (danielwa) <danielwa@xxxxxxxxx> > > Sent: Wednesday, April 8, 2020 12:35 AM > > To: Y.b. Lu <yangbo.lu@xxxxxxx> > > Cc: stable@xxxxxxxxxxxxxxx; Shyam More (shymore) <shymore@xxxxxxxxx>; > > xe-linux-external(mailer list) <xe-linux-external@xxxxxxxxx>; Ulf Hansson > > <ulf.hansson@xxxxxxxxxx> > > Subject: Re: mmc: sdhci-of-esdhc: fix P2020 errata handling > > > > On Wed, Apr 01, 2020 at 03:26:35PM +0000, Daniel Walker (danielwa) wrote: > > > On Wed, Apr 01, 2020 at 05:12:44AM +0000, Y.b. Lu wrote: > > > > Hi Daniel, > > > > > > > > Sorry for the trouble. > > > > I think you were saying below patch introduced issue for you. > > > > fe0acab mmc: sdhci-of-esdhc: fix P2020 errata handling > > > > > > Yes, this patch cased mmc to stop functioning on p2020. > > > > > > > Have you investigated this ? > > As I said, this patch was proper fix-up, fixing mistake which used host->quirks2. It was host->quirks that should be used. > But after this patch, the other potential issues for P2020 appeared. Your including a change into stable which breaks p2020, that's not acceptable. If more changes are needed to make p2020 stable can you send those additional patches to stable also ? Otherwise we need to revert your current patch. Daniel
