Hi Daniel, > -----Original Message----- > From: Daniel Walker (danielwa) <danielwa@xxxxxxxxx> > Sent: Wednesday, April 8, 2020 12:35 AM > To: Y.b. Lu <yangbo.lu@xxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx; Shyam More (shymore) <shymore@xxxxxxxxx>; > xe-linux-external(mailer list) <xe-linux-external@xxxxxxxxx>; Ulf Hansson > <ulf.hansson@xxxxxxxxxx> > Subject: Re: mmc: sdhci-of-esdhc: fix P2020 errata handling > > On Wed, Apr 01, 2020 at 03:26:35PM +0000, Daniel Walker (danielwa) wrote: > > On Wed, Apr 01, 2020 at 05:12:44AM +0000, Y.b. Lu wrote: > > > Hi Daniel, > > > > > > Sorry for the trouble. > > > I think you were saying below patch introduced issue for you. > > > fe0acab mmc: sdhci-of-esdhc: fix P2020 errata handling > > > > Yes, this patch cased mmc to stop functioning on p2020. > > > > Have you investigated this ? As I said, this patch was proper fix-up, fixing mistake which used host->quirks2. It was host->quirks that should be used. But after this patch, the other potential issues for P2020 appeared. I had shared you all other related fix-ups for P2020. If your linux doesn't not have, you need to cherry-pick by yourself. 80c7482 mmc: sdhci-of-esdhc: fix serious issue clock is always disabled 429d939 mmc: sdhci-of-esdhc: fix transfer mode register reading 1b21a70 mmc: sdhci-of-esdhc: fix clock setting for different controller versions 2aa3d82 mmc: sdhci-of-esdhc: fix esdhc_reset() for different controller versions f667216 mmc: sdhci-of-esdhc: re-implement erratum A-009204 workaround At least, if you try to cherry-pick the two patches, P2020 eSDHC would work again. 2aa3d82 mmc: sdhci-of-esdhc: fix esdhc_reset() for different controller versions f667216 mmc: sdhci-of-esdhc: re-implement erratum A-009204 workaround Thanks. > > Daniel
