Hi Daniel, Sorry for the trouble. I think you were saying below patch introduced issue for you. fe0acab mmc: sdhci-of-esdhc: fix P2020 errata handling Actually it looked fine from code. Probably it resolved its own issue but caused another. I don't know which kernel you were using. Could you have a check whether my other fix-up patches which may be related to P2020 in your kernel after that one? I remembered P2020 should work. 80c7482 mmc: sdhci-of-esdhc: fix serious issue clock is always disabled 429d939 mmc: sdhci-of-esdhc: fix transfer mode register reading 1b21a70 mmc: sdhci-of-esdhc: fix clock setting for different controller versions 2aa3d82 mmc: sdhci-of-esdhc: fix esdhc_reset() for different controller versions f667216 mmc: sdhci-of-esdhc: re-implement erratum A-009204 workaround Thanks a lot. Best regards, Yangbo Lu > -----Original Message----- > From: Daniel Walker (danielwa) <danielwa@xxxxxxxxx> > Sent: Wednesday, April 1, 2020 4:50 AM > To: Y.b. Lu <yangbo.lu@xxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx; Shyam More (shymore) <shymore@xxxxxxxxx>; > xe-linux-external(mailer list) <xe-linux-external@xxxxxxxxx>; Ulf Hansson > <ulf.hansson@xxxxxxxxxx> > Subject: Re: mmc: sdhci-of-esdhc: fix P2020 errata handling > > Hi, > > We got your patch from stable. On p2020 we had mmc issues, and bisected > the > issue to your patch. > > Both prior patches seems to modify quirks2. > > Fixes: 05cb6b2a66fa ("mmc: sdhci-of-esdhc: add erratum eSDHC-A001 > and A-008358 support") > Fixes: a46e42712596 ("mmc: sdhci-of-esdhc: add erratum eSDHC5 > support") > > So I'm not sure if your changes were done correctly. > > > Daniel