On Wed, Apr 01, 2020 at 05:12:44AM +0000, Y.b. Lu wrote: > Hi Daniel, > > Sorry for the trouble. > I think you were saying below patch introduced issue for you. > fe0acab mmc: sdhci-of-esdhc: fix P2020 errata handling Yes, this patch cased mmc to stop functioning on p2020. > Actually it looked fine from code. Probably it resolved its own issue but caused another. > I don't know which kernel you were using. Could you have a check whether my other fix-up patches which may be related to P2020 in your kernel after that one? > I remembered P2020 should work. We are using 4.9 stable. Your patch changes from quirks2 to quirks, but the original patches all use quirks2. > 80c7482 mmc: sdhci-of-esdhc: fix serious issue clock is always disabled > 429d939 mmc: sdhci-of-esdhc: fix transfer mode register reading > 1b21a70 mmc: sdhci-of-esdhc: fix clock setting for different controller versions > 2aa3d82 mmc: sdhci-of-esdhc: fix esdhc_reset() for different controller versions > f667216 mmc: sdhci-of-esdhc: re-implement erratum A-009204 workaround These are all 5.5 time frame patches, unless it's in stable we don't have them. Daniel