Re: Linux 4.9.6 ( Restore IO-APIC irq_chip retrigger callback , breaks my box )

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 14 Feb 2017, Thomas Gleixner wrote:
> Gabriel, can you please apply the debug patch below instead of the one
> Linus sent, so we can get some more information about this. Can you upload
> /proc/interrupts as well? The last one I've seen does not have e1000 in it.
> 
> Leave GOLDFISH and WBT disabled for now.

Here is a better one. Please turn on GOLDFISH and leave WBT disabled unless
you have Jens patch applied.

That should give us the connection between the retrigger and the goldfish
irq firing.

output from lspci -vvv would be helpful as well.

Thanks,

	tglx
---
--- a/drivers/platform/goldfish/pdev_bus.c
+++ b/drivers/platform/goldfish/pdev_bus.c
@@ -154,10 +154,17 @@ static int goldfish_new_pdev(void)
 	return 0;
 }
 
+extern int stop_crap;
+
 static irqreturn_t goldfish_pdev_bus_interrupt(int irq, void *dev_id)
 {
 	irqreturn_t ret = IRQ_NONE;
-	while (1) {
+
+	if(!stop_crap) {
+		pr_info("Goldfish IRQ\n");
+		stop_crap = 1;
+	}
+	while (0) {
 		u32 op = readl(pdev_bus_base + PDEV_BUS_OP);
 		switch (op) {
 		case PDEV_BUS_OP_DONE:
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -1088,6 +1088,8 @@ int irq_chip_set_type_parent(struct irq_
 }
 EXPORT_SYMBOL_GPL(irq_chip_set_type_parent);
 
+int stop_crap;
+
 /**
  * irq_chip_retrigger_hierarchy - Retrigger an interrupt in hardware
  * @data:	Pointer to interrupt specific data
@@ -1098,9 +1100,11 @@ EXPORT_SYMBOL_GPL(irq_chip_set_type_pare
 int irq_chip_retrigger_hierarchy(struct irq_data *data)
 {
 	for (data = data->parent_data; data; data = data->parent_data)
-		if (data->chip && data->chip->irq_retrigger)
+		if (data->chip && data->chip->irq_retrigger) {
+			if (!stop_crap)
+				pr_info("Retrigger %s %u\n", data->chip->name, data->irq);
 			return data->chip->irq_retrigger(data);
-
+		}
 	return 0;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]