On Mon, 13 Feb 2017, Linus Torvalds wrote:
> On Mon, Feb 13, 2017 at 1:35 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> >
> > arch/x86/platform/goldfish/goldfish.c
> >
> > static int __init goldfish_init(void)
> > {
> > platform_device_register_simple("goldfish_pdev_bus", -1,
> > goldfish_pdev_bus_resources, 2);
> > return 0;
> > }
> > device_initcall(goldfish_init);
> >
> > So it unconditionallyt registers that platform device, which has IRQ 4 as
> > irq resource and the driver happily matches on the platform devices.
> >
> > Wonderful crap, isn't it? It should be made 'depend on BROKEN'.
>
> Ugh. Yeah, that's crazy. Random hardcoded interfaces that get enabled
> by people by mistake.
>
> And yeah, it's not just the irq. It just randomly sets up memory addresses too.
>
> That thing needs to be disabled some way. Maybe not marked "broken",
> but there needs to be something that actually enables it at runtime
> (like a kernel command line option or something like that).
>
> That said - that code was presumably enabled before too, so why would
> this break something? And if this is the cause, we need to figure out
> what it is that it then triggers..
I'm on it ...
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html