On Tue, 14 Feb 2017, Greg Kroah-Hartman wrote:
> On Tue, Feb 14, 2017 at 03:49:57PM +0100, Thomas Gleixner wrote:
> > On Tue, 14 Feb 2017, Thomas Gleixner wrote:
> > > On Mon, 13 Feb 2017, Linus Torvalds wrote:
> > > > On Mon, Feb 13, 2017 at 1:35 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > > > >
> > > > > arch/x86/platform/goldfish/goldfish.c
> > > > >
> > > > > static int __init goldfish_init(void)
> > > > > {
> > > > > platform_device_register_simple("goldfish_pdev_bus", -1,
> > > > > goldfish_pdev_bus_resources, 2);
> > > > > return 0;
> > > > > }
> > > > > device_initcall(goldfish_init);
> > > > >
> > > > > So it unconditionallyt registers that platform device, which has IRQ 4 as
> > > > > irq resource and the driver happily matches on the platform devices.
> > > > >
> > > > > Wonderful crap, isn't it? It should be made 'depend on BROKEN'.
> > > >
> > > > Ugh. Yeah, that's crazy. Random hardcoded interfaces that get enabled
> > > > by people by mistake.
> > > >
> > > > And yeah, it's not just the irq. It just randomly sets up memory addresses too.
> > > >
> > > > That thing needs to be disabled some way. Maybe not marked "broken",
> > > > but there needs to be something that actually enables it at runtime
> > > > (like a kernel command line option or something like that).
> >
> > I prefer to mark it broken, because that's what it is, but we can add a
> > command line option as well. See below.
>
> I have no problem marking all of the Goldfish stuff broken as it seems
> to be a "dead" platform at the moment, no one is providing any updates
> or cares about it, and the only users I know of it are using a _very_
> old kernel version (the Android emulator).
>
> Want me to send a patch for that as I think the Goldfish stuff
> originally came through my tree...
Alternatively we can add a command line option 'goldfish' to the
x86/platform code which prevents the creation of platform device if not
set. Either way is fine.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html