On 12/06/2014 04:04 AM, Fabiano Fidêncio wrote:
On Fri, Dec 5, 2014 at 11:08 PM, Marc-André Lureau wrote:
On Fri, Dec 5, 2014 at 10:38 PM, Jonathon Jongsma wrote:
For what it's worth, I basically agree with Christophe and Jeremy.
I agree with Marc-André here.
I too agree with Marc-Andre about _trivial_ patches (such as typo fixing).
For any non-trivial patch, a review should be performed.
Just to finish, IMHO, this patch, specifically, was not a trivial one.
The problem here is that "trivial" is subjective.
I view this specific patch as not trivial, as it practically replaces
the whole file.
I understand why Marc-Andre thinks it is trivial as the result of it is
a common autogen.sh.
Thanks,
Uri.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel