On Fri, Dec 05, 2014 at 06:03:42PM +0100, Marc-André Lureau wrote: > On Fri, Dec 5, 2014 at 5:43 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > What is so bad with having a commit delayed for a few hours while it's > > waiting for reviews? > > It is mainly the difference between asking someone to take an action > or not. And asking someone take time often longer than necessary. I don't understand why it's bad for the project, or why it makes things worse. > >> Btw, do you apply your own rules in your own projects? > > > > I don't really have a project of mine in mind where a second person is > > actively involved, which is a prerequisite to set up such a system. > > I'd be happy to switch to that model if I had the opportunity. If > > someone was to take over libgovirt maintainance, I'd be happy to send > > patches before committing. > > libgovirt is used by virt-viewer, and it means the Spice and > virt-tools team are affected by your changes. You can always ask for > help, but you trust enough your own work to do it alone Actually I don't and often feel uncomfortable making changes without anyone looking at them. > Similarly, I would like you trust contributors to do the right thing > for Spice, without mandatory code review. I'd prefer if we did not frame this in term of trusting people or not, this is not what this is about. We are all humans, we all make mistakes, and we all have different skills. Patch reviews are just a way to tap into other people skillsets in order to improve the project overall, and to try to avoid these human mistakes as much as possible. > There has been no big issues so far, only you complaining for no valid > technical reasons. Let's stick to that before enforcing rules. Well, I did complain, Jeremy did too. Coming getting pushed "because they are trivial" is something newish and mostly done by you. I don't think the obvious conclusion to this discussion is to just do whatever you decided, quite the contrary. Let's stop trying to be smart in deciding what is trivial or not, and let's keep sending all patches to the ML, this is not a big constraint, and will result in less frictions. Christophe
Attachment:
pgpPgbKjQkUSu.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel