On Fri, Dec 05, 2014 at 03:57:29PM +0100, Marc-André Lureau wrote: > Ok, but a commit message is not as important as the change itself, > although it's not reversible. But it's far from being unimportant. > The blame will be anyway on the one who > typed it forever. I have absolutely no interest in blaming people after the fact, I prefer to fix things before the mistake happens ;) > Nothing like replacing a crufted autogen with an obvious autoreconf. Is this what you did? This is not what I read in the commit log. > Quick for me is a matter of minutes. Even if it's a few hours, or a few days, is it a big deal? > There are a lot of trivial patches that have been pending for days. This means we need to improve on reviews :) Any pointers? > Improving the change can be done immediately upstream or by a > after-commit review. That's not a valid argument. With pre-commit review, you ensure that at least one person read the patch. With post-commit review, you have no such guarantee. > And yet, there is no ACL per project for the reason that we trust each > other doing the right thing and it works well. Yes, for example modules who want mandatory reviews trust others not to push without a review ;) > >> It's really not much, if > >> the change is wrong, it can be reverted, not a big deal. > > > > Not a big deal save for history cluttering, the need to be careful when > > backporting patches if the commit was followed by a fixup commit, no way > > for fixing commit log typos, or for adding missing information, ... > > It's also cluttering the mailing list, you moved the problem. You have > to weight the cost of applying strict rules. I have a different > opinion on that. If the clutter on mailing lists is that bad, there's an easy solution, a spice-users mailing list in addition to spice-devel. git history is what you have to look at everyday, mailing lists history, not so often. Christophe
Attachment:
pgpcCe34V702i.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel