On Fri, Dec 05, 2014 at 03:49:55PM -0600, Jonathon Jongsma wrote: > I don't have strong opinions on moving these checks into macros (or the > following patches that extract additional macros), but > - Do they really need to all be in their own files? From a readability > point of view, I think it's nicer to be able to browse all of these > macros at once rather than opening a separate file to inspect each one Oh I can merge them in a single file, there are no particular reason why they are separate > - In general, it'd be nice if the m4 macros had their arguments > documented in a comment at the top of the macro. Then you don't have to > read the whole implementation to find out how to use them. Ok, I'll add that. Christophe
Attachment:
pgp9ldpzs6LKn.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel