Re: [PATCH 4/7] spice-ppc: fix glz magic endianess

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/08/2012 12:34 PM, Christophe Fergeau wrote:
On Wed, Aug 08, 2012 at 05:24:30AM -0400, Yaniv Kaul wrote:
----- Original Message -----
On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote:
From: Erlon Cruz <erlon.cruz@xxxxxxxxxxxxxxxxxx>

Signed-off-by: Erlon R. Cruz <erlon.cruz@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Fabiano Fidêncio
<Fabiano.Fidêncio@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Rafael F. Santos
<Rafael.Santos@xxxxxxxxxxxxxxxxxxxxx>
---
  server/glz_encoder.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/server/glz_encoder.c b/server/glz_encoder.c
index 1ec1f9b..f8415a8 100644
--- a/server/glz_encoder.c
+++ b/server/glz_encoder.c
@@ -261,7 +261,7 @@ int glz_encode(GlzEncoderContext
*opaque_encoder,
      encoder->cur_image.id = dict_image->id;
      encoder->cur_image.first_win_seg = dict_image->first_seg;
- encode_32(encoder, LZ_MAGIC);
+    encode_32(encoder, htole32(LZ_MAGIC));
The correct thing to do here is drop LZ_MAGIC. No one needs it.
And the version stuff that follows it as well. It's useless.
It's not useless to old clients as they won't be able to communicate with
the server if these fields are not there. I think some people would hate us
if we broke that ;)

Christophe

Of course - this should all have a "if you are already touching this field" notice/pledge.
Y.


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]