Re: [PATCH 4/7] spice-ppc: fix glz magic endianess

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote:
> From: Erlon Cruz <erlon.cruz@xxxxxxxxxxxxxxxxxx>
> 
> Signed-off-by: Erlon R. Cruz <erlon.cruz@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabiano Fidêncio <Fabiano.Fidêncio@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Rafael F. Santos <Rafael.Santos@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  server/glz_encoder.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/server/glz_encoder.c b/server/glz_encoder.c
> index 1ec1f9b..f8415a8 100644
> --- a/server/glz_encoder.c
> +++ b/server/glz_encoder.c
> @@ -261,7 +261,7 @@ int glz_encode(GlzEncoderContext *opaque_encoder,
>      encoder->cur_image.id = dict_image->id;
>      encoder->cur_image.first_win_seg = dict_image->first_seg;
>  
> -    encode_32(encoder, LZ_MAGIC);
> +    encode_32(encoder, htole32(LZ_MAGIC));

LZ_MAGIC really should be a string that we encode using something like
encode_array(encoder, LZ_MAGIC, sizeof(LZ_MAGIC)), but we don't have such
facilities in glz_encoder.c, so why not. Have you tested that a ppc encoded
glz stream can be decoded on an x86 client? (thinking of it, it might be
the only setup you have tested for now).

Christophe

Attachment: pgpIQIxnxzMUe.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]