Re: [PATCH 33/39] reiserfs: split right balancing part of balance_leaf() off

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2007-06-07 at 18:01 -0400, Jeff Mahoney wrote:
> Vladimir V. Saveliev wrote:
[cut] 
> > shouldn't function name prefixes be more consistent? Either bl_ or
> > balance_leaf everywhere?
> > 
> 
> Yes, absolutely. Initially they were, but
> balance_leaf_function_subfunction(parameter list) ended up with the
> parameters grouped along the right margin. I wouldn't be opposed to
> changing them all to bl_* except for balance_leaf itself.

Or you could trade vertical space for horizontal space and do like:

static void
balance_leaf_right_paste_de_partial(
	struct tree_balance *tb, struct item_head *ih,
	const char *body, int flag, int *zeros_num,
	int item_pos, int *pos_in_item
) {

I always thought wasting all that horizontal space in parameter lists
was silly just to save some vertical, and so many people get the
tab-stop/space mix wrong.
-- 
Zan Lynx <zlynx@xxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux File System Development]     [Linux BTRFS]     [Linux NFS]     [Linux Filesystems]     [Ext4 Filesystem]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Resources]

  Powered by Linux