-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Vladimir V. Saveliev wrote:
> Hello
>
> Jeff Mahoney wrote:
>> This is the second in a set of 4 patches that split balance_leaf up into
>> a group of functions rather than the 2500 beast it once was.
>>
>> This patch splits off the right-tree balancing behavior.
>>
>> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>
>> ---
>> fs/reiserfs/do_balan.c | 671 +++++++++++++++++++++----------------------------
>> 1 file changed, 290 insertions(+), 381 deletions(-)
>>
>> --- a/fs/reiserfs/do_balan.c 2007-05-30 17:54:43.000000000 -0400
>> +++ b/fs/reiserfs/do_balan.c 2007-05-30 17:55:02.000000000 -0400
>> @@ -587,6 +587,293 @@ balance_leaf_left(struct tree_balance *t
>> pos_in_item);
>> }
>>
>> +static void
>> +balance_leaf_right_insert(struct tree_balance *tb, struct item_head *ih,
>> + const char *body, int flag, int *zeros_num,
>> + int item_pos)
>> +{
>
> [snip]
>
>
>> +
>> +static void
>> +bl_right_paste_de_partial(struct tree_balance *tb, struct item_head *ih,
>> + const char *body, int flag, int *zeros_num,
>> + int item_pos, int *pos_in_item)
>> +{
>
> shouldn't function name prefixes be more consistent? Either bl_ or
> balance_leaf everywhere?
>
Yes, absolutely. Initially they were, but
balance_leaf_function_subfunction(parameter list) ended up with the
parameters grouped along the right margin. I wouldn't be opposed to
changing them all to bl_* except for balance_leaf itself.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFGaIBTLPWxlyuTD7IRApgdAJ9Et2+LGYthhbcynmiRr6PIzXk2IwCaAo8Z
JIKK05IZaEWXn8fpwZQt/bo=
=40G+
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
