On Wed, 12 Jun 2013 22:45:08 -0400 (EDT) Joe Lawrence <joe.lawrence@xxxxxxxxxxx> wrote: > On Wed, 12 Jun 2013, NeilBrown wrote: > > > I've applied that patch below - thanks. > > > > NeilBrown > > > > > > From b12c24ee0fce802f35263da65d236694b01c99cf Mon Sep 17 00:00:00 2001 > > > From: Joe Lawrence <joe.lawrence@xxxxxxxxxxx> > > > Date: Fri, 7 Jun 2013 15:25:54 -0400 > > > Subject: [PATCH] raid1: properly set blk_queue_max_write_same_sectors > > > > [snip patch] > > Hi Neil -- this patch was only to test out what RAID1 would do if the > blk_queue_max_write_same_sectors were set to enable WRITE SAME. As HPA > and Martin point out, we should be disabling WRITE SAME for raid1/10 in > 3.10 / stable for now. Sorry for the confusion. > > -- Joe Ahh - thanks. the code your patch removes is clearly wrong as chunk size doesn't mean anything useful for raid1, but as you say we need to actually disable it, so may as well do that at the same time as removing the error. Thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature
