On Wed, 5 Jun 2013 12:29:32 -0700 (PDT) "Martin K. Petersen" <martin.petersen@xxxxxxxxxx> wrote: > >>>>> "hpa" == H Peter Anvin <hpa@xxxxxxxxx> writes: > > hpa> Yuck, this suddenly got complex. Perhaps WRITE SAME should simply > hpa> be disabled on raid1/raid10 until this can be addressed? > > Yeah, maybe. Martin, I'm looking at the changes in raid1.c and am confused as to why we did this in the first place (commit c8dc9c6): if (mddev->queue) blk_queue_max_write_same_sectors(mddev->queue, mddev->chunk_sectors); for RAID1, aren't chunk_sectors always going to be zero? (At least on my machine, /sys/block/md*/queue/write_same_max_bytes for all md RAID1 devices are set to 0.) This would have the effect of rendering bdev_write_same() always false for these MD devices. -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html