>>>>> "hpa" == H Peter Anvin <hpa@xxxxxxxxx> writes: hpa> Yuck, this suddenly got complex. Perhaps WRITE SAME should simply hpa> be disabled on raid1/raid10 until this can be addressed? Yeah, maybe. hpa> Do we need to do the same for DISCARD? For discard we have better heuristics from the device so the partial completion case should be rare. But obviously a disk can reject a command anytime with or without reason... Also, discard is advisory. There is no guarantee that a pair of mirrored drives will be consistent in the discarded region (unless the drives promise to zero discarded blocks but MD doesn't check that for raid1/raid10). WRITE SAME requires strict consistency between the devices, however. So it looks like there's some work that needs to be done in that department. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html