Hello, Dan Williams wrote: > Please also take a look at this cleanup patch that I will queue for > .28. I think it makes things easier to read let me know if you > disagree. > Look good for me. Hmm, actually I don't think that current version is so hard to read... Just one comment: > - if (!next) > + if (dep) > + chan = dep->chan; > + else > return; > I don't like 'return' inside 'else'. Regards, Ilya. -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html