On Thursday January 15, akpm@osdl.org wrote:
> NeilBrown <neilb@cse.unsw.edu.au> wrote:
> >
> > + if (sh == NULL) {
> > + sh = get_active_stripe(conf, sector_nr, pd_idx, 0);
> > + /* make sure we don't swamp the stripe cache if someone else
> > + * is trying to get access
> > + */
> > + yield();
> > + }
>
> In 2.6, yield() has utterly awful behaviour when there are a lot of other
> runnable tasks.
>
> Have you tested this when the kernel is busy doing other stuff, like a
> `make -j2' or a few busywait loops? You might find that rebuild simply
> stops.
>
No I haven't, and I'm not near my test box today, so it would be
awkward.
No other patches are dependant on that one so you can just leave it
out if you like.
I just want to wait until every other runnable process has had a
turn. Maybe cond_resched() would be better?? I try some things out.
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
