Re: [PATCH] md - 2 of 10 - Don't allow raid5 rebuild to swamp raid5 stripe cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



NeilBrown <neilb@cse.unsw.edu.au> wrote:
>
> +	if (sh == NULL) {
> +		sh = get_active_stripe(conf, sector_nr, pd_idx, 0);
> +		/* make sure we don't swamp the stripe cache if someone else
> +		 * is trying to get access 
> +		 */
> +		yield();
> +	}

In 2.6, yield() has utterly awful behaviour when there are a lot of other
runnable tasks.

Have you tested this when the kernel is busy doing other stuff, like a
`make -j2' or a few busywait loops?  You might find that rebuild simply
stops.


-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux