On Monday March 11, gody@master.slon.net wrote:
> On Fri, 8 Mar 2002, Neil Brown wrote:
>
> Hi !
>
> I tried latest patch but still no cigar :((
Could you tell me exactly what happened?
I think that the Oops in raid5d that you were getting before was due
to a typo in the patch that I fixed in my testing but that didn't
manage to get into the distributed patch:
--- ./drivers/md/raid5.c 2002/02/27 01:20:36 1.1
+++ ./drivers/md/raid5.c 2002/02/27 04:57:36 1.2
@@ -1293,8 +1293,12 @@
handled = 0;
- if (mddev->sb_dirty)
- md_update_sb(mddev);
+ if (mddev->sb_dirty) {
+ lock_mddev(&mddev);
---------------------------^ shouldn't have been there.
+ if (mddev->sb_dirty)
+ md_update_sb(mddev);
+ unlock_mddev(mddev);
+ }
md_spin_lock_irq(&conf->device_lock);
while (1) {
struct list_head *first;
Are you still getting an Oops with the new patch, or is it just the
BUG message?
Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
