Re: Raid5 race patch (fwd)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 13 Mar 2002, Neil Brown wrote:

> Could you tell me exactly what happened?

cat /proc/mdstat stalls in D state. Can't be interrupted.


> I think that the Oops in raid5d that you were getting before was due
> to a typo in the patch that I fixed in my testing but that didn't
> manage to get into the distributed patch:
> 
> --- ./drivers/md/raid5.c	2002/02/27 01:20:36	1.1
> +++ ./drivers/md/raid5.c	2002/02/27 04:57:36	1.2
> @@ -1293,8 +1293,12 @@
>  
>  	handled = 0;
>  
> -	if (mddev->sb_dirty)
> -		md_update_sb(mddev);
> +	if (mddev->sb_dirty) {
> +		lock_mddev(&mddev);
> ---------------------------^  shouldn't have been there.
> +		if (mddev->sb_dirty)
> +			md_update_sb(mddev);
> +		unlock_mddev(mddev);
> +	}
>  	md_spin_lock_irq(&conf->device_lock);
>  	while (1) {
>  		struct list_head *first;
> 
> 
> Are you still getting an Oops with the new patch, or is it just the
> BUG message?
> 
Couldn't even came to raidsetfaulty since cat /proc/mdstat was frozen, adn
resinhronization process didn't work for some reason (stucked).

there was some OOPS on reboot process on umount or raidstop (after that
OOPS hard reboot was necessary) but it is not logged, so I can't send it.

It looks to me, that new locking scheme locks something and doesn't unlock
and processes like syhronization and cat /proc/mdstat can't work and
blocks.


	lp
		gody

> Thanks,
> NeilBrown
> 

__________________________________________________________________
|    Matjaz Godec    |    Agenda d.o.o.    |   ISP for business  |
|   Tech. Manager    |   Gosposvetska 84   |     WAN networks    |
|   gody@slon.net    |   si-2000 Maribor   |  Internet/Intranet  |
| tel:+386.2.2340860 |      Slovenija      | Application servers |
|http://www.slon.net |http://www.agenda.si |  Caldera OpenLinux  |

-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux