Re: [PATCH v13 10/10] bluetooth: policy: Treat bi-directional A2DP profiles as suitable for VOIP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The SRC (PA) does not announce XQ bitpool. It takes the max bitpool value announce by the SNK (the BT device) and then decide if XQ is possible, or not, depending on the value announced by the SNK and its ability to do dual channel (also announced by the SNK during negociation).
As stated in the README of my patch : in case the device can't do XQ : PA falls back to legacy bitpool. 

JP

14:52, 17 octobre 2019, "Tanu Kaskinen" <tanuk@xxxxxx>:

On Tue, 2019-10-08 at 18:29 +0200, Pali Rohár wrote:

 Automatic SBC profile is not going to be changed. It is there to support
 all devices without any tweaks. ValdikSS already did more tests and
 there are devices which do not work with higher SBC bitpool. So
 increasing max value of bitpool in Automatic SBC profile would lead to
 broken support for these devices and therefore regressions.

 As Automatic SBC profile is the only one available for systems where
 codec switching is not supported, it would mean complete regression as
 these devices completely stops working on those systems.

 Upgrading either pulseaudio or bluez must not lead to problem that some
 bluetooth devices stop working (if they worked before upgrade).

 So no, there would not be any changes in Automatic SBC profile. This one
 should stay untouched, to make it always working with all existing
 devices without any regression.


I wasn't aware that advertising the XQ settings during negotiation
breaks some devices. I guess this means that JP Guillaume's SBC XQ
patch can't be accepted, assuming that we value avoiding regressions
more than the improved quality for most headsets?

Here's that patch:
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/177

--
Tanu


https://www.patreon.com/tanuk
https://liberapay.com/tanuk



--
Sent from Yandex.Mail for mobile
_______________________________________________
pulseaudio-discuss mailing list
pulseaudio-discuss@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux