Hello Colin. On Thu, 2014-09-18 at 15:27 +0200, Colin Leroy wrote: > On Thu, 18 Sep 2014 19:17:53 +0600, "Alexander E. Patrakov" > <patrakov at gmail.com> wrote: > > > I had a look at the diff between the master and the end result. Too > > much whitespace changes and other non-functional changes (e.g. I > > don't understand why the definition of struct userdata has to be > > moved up in odule-raop-discover.c). I have not looked at the > > individual commits. > > Most of the whitespace changes are actually extra whitespace removal. Do > you think I should revert those? I agree that they make the diff > longer, but that seems like wasting the time of the people who did > these fixes... > > > Also, you have some "unimplemented" stuff like AAC encoding. Could > > you please remove it? We can always use ALAC, and already have a > > presumably-working standalone "encoder" (that just slaps a header > > with an is-not-compressed bit) implementation in write_ALAC_data(). > > Sure. You'll find a patch attached. > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-raop-Remove-unimplemented-code-PCM-and-AAC.patch Type: text/x-patch Size: 3433 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20140925/fc46cdc6/attachment-0001.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20140925/fc46cdc6/attachment-0001.sig>
