Hello Colin ! On Tue, 2014-09-16 at 22:47 +0200, Colin Leroy wrote: > On 16 September 2014 at 18h53, Colin Leroy wrote: > > Hi, > > > > Done. Please let me know if you have difficulties rebasing this on > > > top of 5.0. > > > > I've rebased everything to my branch, it seems to work fine for me. > > Almost fine - the client's seq number, being uint16_t, wraps around > 0xFFFF in less than five minutes of playback. It makes > raop-packet-buffer assert. > > I've implemented that attached patch to wrap around to the initial > seqnum, and I have continuous playback since more than one hour :) Good ! As mentioned in my previous reply I'll do some tests next week. Concerning the patch you should consider the fix attached, otherwise, `gcc -Wdeclaration-after-statement` will warn that declarations have been mixed with code. You should also try not to use tabs in your code, you can refer to this page for coding style guidelines : http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/Developer/CodingStyle > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss -------------- next part -------------- A non-text attachment was scrubbed... Name: Keep_gcc_ISO_C90_quiet.patch Type: text/x-patch Size: 575 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20140917/4c948764/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20140917/4c948764/attachment.sig>
