18.09.2014 19:03, Colin Leroy wrote: > On Thu, 18 Sep 2014 16:43:05 +0530, Arun Raghavan <arun at accosted.net> > wrote: > >> On 18 Sep 2014 15:35, "Colin Leroy" <colin at colino.net> wrote: >>> >>> On Thu, 18 Sep 2014 11:10:30 +0200, Colin Leroy <colin at colino.net> >>> wrote: >>> >>>>> So what's needed to start looking at pushing this upstream? I >>>>> don't have any ROAP devices to test with, but can try to help >>>>> with reviews (and maybe hunt for something that can do ROAP ... >>>>> XBMC?). >>>> >>>> I just have to brace myself and send the patchset for review! >>> >>> There are 55 of them, is it OK to send them here? >> >> That would get messy quickly. A link to a branch would work better. >> If it's already on GitHub, we could just use the review mechanism >> there for simplicity. > > Thanks. I hope I've done that well; my first repository wasn't ideally > planned (with everything in master), I've made a new one. > > The branch is raop2 at https://github.com/colinleroy/pulseaudio > > You can see all commits there: > > https://github.com/colinleroy/pulseaudio/compare/pulseaudio:master...raop2 > > Thanks in advance. I had a look at the diff between the master and the end result. Too much whitespace changes and other non-functional changes (e.g. I don't understand why the definition of struct userdata has to be moved up in odule-raop-discover.c). I have not looked at the individual commits. Also, you have some "unimplemented" stuff like AAC encoding. Could you please remove it? We can always use ALAC, and already have a presumably-working standalone "encoder" (that just slaps a header with an is-not-compressed bit) implementation in write_ALAC_data(). -- Alexander E. Patrakov
