On Mon, Jul 29, 2013 at 7:53 AM, Tanu Kaskinen
<tanu.kaskinen at linux.intel.com> wrote:
> On Thu, 2013-07-25 at 00:19 -0300, Jo?o Paulo Rechi Vita wrote:
>> On Jul 18, 2013 11:25 AM, "Tanu Kaskinen" <tanu.kaskinen at linux.intel.com>
>> wrote:
>> >
>> > On Fri, 2013-07-12 at 15:06 -0300, jprvita at gmail.com wrote:
>> > > From: Jo?o Paulo Rechi Vita <jprvita at openbossa.org>
>> > >
>> > > Create a structure pa_bluetooth_device to store information about the
>> > > bluetooth device and utility functions to manipulate this structure.
>> > > ---
>> > > src/modules/bluetooth/bluez5-util.c | 84
>> +++++++++++++++++++++++++++++++++++++
>> > > src/modules/bluetooth/bluez5-util.h | 18 ++++++++
>> > > 2 files changed, 102 insertions(+)
>> > >
>> > > diff --git a/src/modules/bluetooth/bluez5-util.c
>> b/src/modules/bluetooth/bluez5-util.c
>> > > index d5f1846..574a22d 100644
>> > > --- a/src/modules/bluetooth/bluez5-util.c
>> > > +++ b/src/modules/bluetooth/bluez5-util.c
>> > > @@ -44,8 +44,86 @@ struct pa_bluetooth_discovery {
>> > > pa_dbus_connection *connection;
>> > > bool filter_added;
>> > > pa_hook hooks[PA_BLUETOOTH_HOOK_MAX];
>> > > + pa_hashmap *devices;
>> > > };
>> > >
>> > > +static pa_bluetooth_device*
>> pa_bluetooth_discovery_create_device(pa_bluetooth_discovery *y, const char
>> *path) {
>> >
>> > Static functions shouldn't have the "pa_bluetooth" prefix. Since this
>> > seems to be a normal object allocation function, I'd use name
>> > "device_new".
>> >
>>
>> Ok, I didn't remember of this requirement in PA. I'll fix this and other
>> occurrences of this problem for the next patch series.
>
> If you haven't done this change yet, I propose that you do it in a
> separate patch on top of the existing patch set, to make reviewing
> easier (fewer changes in the existing patches).
>
This is already changed.
> The same goes for the pa_bluetooth/pa_bluez5 renaming, if you are going
> to do that.
>
Ok, I'll fill this problem in a separate patch.
--
Jo?o Paulo Rechi Vita
http://about.me/jprvita
