On Fri, 2013-07-26 at 02:51 -0300, Jo?o Paulo Rechi Vita wrote: > Yes, and this code is very complex and sensible, thanks a lot for such > a detailed review. But because of all the pending patches in this > series and the other ~15 to come that implements HSP/HFP support, I > suggest that we merge this piece of code how it is atm, since it has > been tested for a long time (it's basically the same code from BlueZ 4 > support), and take care of the comments on this patch and 53/56 after > the release, what do you think? Separate patches are totally fine, it will make also my work easier. As for waiting for the release, I think you should fix the issues as soon as you have time. Whether or not those fixes will go to the release remains to be seen. -- Tanu