2011/11/8 David Henningsson <david.henningsson at canonical.com>: > On 11/03/2011 07:33 PM, Tanu Kaskinen wrote: >> >> This looks good too. I'd really like the pa_device_port_hashmap_free() >> function behavior change to match all other *_free() functions, though. > > I do acknowledge the consistency argument, but I think we're over-using > asserts in this project in general. From a development perspective, it might > be useful, but from maintaining PA downstream, I'm tired of PA crashing > every time something happens that the developer did not anticipate. > Especially in destructors like this one, we should could try to free what we > can instead of crashing. That's exactly why you should compile without asserts enable for production builds. > In short, assertions are better than nothing, but proper error handling is > better than assertions. > > -- > David Henningsson, Canonical Ltd. > http://launchpad.net/~diwic > _______________________________________________ > pulseaudio-discuss mailing list > pulseaudio-discuss at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss >
