On 11/03/2011 07:33 PM, Tanu Kaskinen wrote: > This looks good too. I'd really like the pa_device_port_hashmap_free() > function behavior change to match all other *_free() functions, though. I do acknowledge the consistency argument, but I think we're over-using asserts in this project in general. From a development perspective, it might be useful, but from maintaining PA downstream, I'm tired of PA crashing every time something happens that the developer did not anticipate. Especially in destructors like this one, we should could try to free what we can instead of crashing. In short, assertions are better than nothing, but proper error handling is better than assertions. -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic
