On 11/03/2011 08:36 PM, Tanu Kaskinen wrote: > Looks good. The only complaint is about the "should never happen" > handling. Would it make sense to commit this one as it is, then anyone caring enough could make a general change of invalid -> pa_assert for all occurences here? (Although, I still think that might be an over-use of asserts. But it's not that important to me in this case.) -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic
