2011/2/25 Becker, VincentX <vincentx.becker at intel.com>: >>From: Maarten Bosmans [mailto:mkbosmans at gmail.com] >>Sent: Friday, February 25, 2011 1:10 AM >>To: Becker, VincentX >>Cc: General PulseAudio Discussion >>Subject: Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log >>feature >> >>The patches were handled at the meeting yesterday >>http://colin.guthr.ie/meetings/pulseaudio-meeting/2011/pulseaudio- >>meeting.2011-02-24-21.02.html >> >>Some changes are necessary, but basically adding the file log target >>is ACKed. The other change about string format handling needs further >>review though. >> >>If you need some help with getting patches ready, I can be of >>assistance, just let me know. >> >>Maarten > > Hi Maarten, > I checked the review comments and there are quite few things I don't fully know/understand. It is spoken about rotation logic at some time. What does it mean exactly ? That's about adding the date to the filename. We don't want to become like logrotate. Just use the filename given by --log-target=file:filename > And Lennart used the "s-o-b" acronym; what does it mean ? ("we don't do s-o-b btw"). I fully agree with the changes proposed and will do them and resend (1 or 2 ?) patches. It should be Ok for the patch generation, I will dig the subject. signed-off-by: we don't use that here, that's more of a kernel thing. > However the second one needs still to wait to be reviewed, right ? Yeah, so make the first patch a complete implementation of the logging to fd, but without any reworking of the way the log messages are formatted, etc. Then if there are any problems with the second patch, the first can still be applied to master. > Thanks > Vincent > > > --------------------------------------------------------------------- > Intel Corporation SAS (French simplified joint stock company) > Registered headquarters: "Les Montalets"- 2, rue de Paris, > 92196 Meudon Cedex, France > Registration Number: ?302 456 199 R.C.S. NANTERRE > Capital: 4,572,000 Euros > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. >
