>From: Maarten Bosmans [mailto:mkbosmans at gmail.com] > >2011/2/23 Becker, VincentX <vincentx.becker at intel.com>: >> Thanks for your review Maarten. So you suggest to split this into >several patches (2). One for the outer implementation and the other for >the inner one. I will try to attend to the irc meeting tomorrow so I can >catch your remarks in real time. > >I'm not sure what you mean by outer and inner implementation. What I >meant was one patch thats adds the option to log to a file (this patch >touches all four files) and one patch that does the metadata, >append_data thing (should only change src/pulsecore/log.c) > >Having two clean patches (see my other comments) tomorrow would help >to keep thing moving in the meeting. Hi Maarten, Here are the 2 patches as you suggested (both patches can be compiled separately). I also integrated one of your remarks, but not all. Like concerning the file naming, as you said it might be a bit too complicated and appending the file or creating a new one might be enough. But it remains a powerful way to debug pulseaudio and it is more direct than using syslog. I also wrote a module dedicated to log PCM samples, configurable for sinks and/or sources with or without their respective sink inputs/source outputs. I will submit it probably next month. Vince > >Sorry for getting this rolling on such a short notice. No problem at all! > >Maarten > >> >> Cheers, >> V. --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Add-a-new-log-target-to-a-file-descriptor-in-daemon-.patch Type: application/octet-stream Size: 16439 bytes Desc: 0001-Add-a-new-log-target-to-a-file-descriptor-in-daemon-.patch URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110224/4e0435a0/attachment.obj> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Format-log-messages-with-generic-prepended-and-appen.patch Type: application/octet-stream Size: 7505 bytes Desc: 0001-Format-log-messages-with-generic-prepended-and-appen.patch URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110224/4e0435a0/attachment-0001.obj>
